Hi Nanda or any one,

When I run the above code. I am getting the below error. Please advise what to change.

Caused by: JCS-122035: Unable to persist: JCS-102090: Object 'Job Definition FILE_COPY_PARAM (Copy from 2015/01/12 15:29:43,477 America/New_York)' of type Job Definition cannot be modified

at com.redwood.scheduler.model.SchedulerSessionImpl.writeDirtyListLocal(SchedulerSessionImpl.java:934)

at com.redwood.scheduler.model.SchedulerSessionImpl.persist(SchedulerSessionImpl.java:875)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEexecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLE.java:user code 32)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.jcsExecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.java:28)

... 13 more

Caused by: com.redwood.scheduler.model.exception.NonModifiableObjectException: JCS-102090: Object 'Job Definition FILE_COPY_PARAM (Copy from 2015/01/12 15:29:43,477 America/New_York)' of type Job Definition cannot be modified

at com.redwood.scheduler.model.method.impl.BranchedUniqueNamedApplicationObjectMethodImpl.vetoPhaseHandler(BranchedUniqueNamedApplicationObjectMethodImpl.java:154)

at com.redwood.scheduler.model.method.impl.JobDefinitionMethodImpl.vetoPhaseHandler(JobDefinitionMethodImpl.java:1058)

Regards,

Ramana

I also tried to change my select statement as below.

String query = "select JobDefinitionParameter.* from JobDefinitionParameter where JobDefinitionParameter.Name = 'DIRECTORY' and BranchedLLPVersion = -1";

But got the below error. Please advise.

Caused by: JCS-122036: An exception occurred during the execution of a persistence layer method

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1100)

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1083)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEexecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLE.java:user code 4)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.jcsExecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.java:28)

... 13 more

Caused by: com.redwood.scheduler.persistence.api.PersistenceException$UnknownField: JCS-XXXXX: Unknown field BranchedLLPVersion in [JobDefinitionParameter] debug:  aliases=true {JobDefinitionParameter=JobDefinitionParameter}

at com.redwood.scheduler.persistence.api.PersistenceException$UnknownField.rethrowInternal(PersistenceException.java:193)

at com.redwood.scheduler.persistence.api.PersistenceException.rethrow(PersistenceException.java:697)

Regards,

Ramana

BranchedLLPVersion is a column in JobDefinition table and you are selecting it in JobDefinitionParameter table.

select Jp.* from JobDefinitionParameter Jp,JobDefiniton Jd where Jp.Name = 'DIRECTORY' and Jp.JobDefinition=Jd.UniqueId and Jd.BranchedLLPVersion = -1

thanks

Nanda

Hello Nanda,

Thank you so much.

I ran the above select statement but received the below error message. Please advise.

Caused by: JCS-122036: An exception occurred during the execution of a persistence layer method

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1100)

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1083)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEexecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLE.java:user code 5)

at com.redwood.scheduler.custom.PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.jcsExecute(PARMETER_TRANSLATION_REPLACE_PARAM_ALL_JOBS_TABLEStub.java:28)

... 13 more

Caused by: com.redwood.scheduler.persistence.api.PersistenceException$UnknownObjectType: JCS-XXXXX: Unknown object type JobDefiniton in  aliases=false {Jp=JobDefinitionParameter, Jd=JobDefiniton}

at com.redwood.scheduler.persistence.api.PersistenceException$UnknownObjectType.rethrowInternal(PersistenceException.java:119)

at com.redwood.scheduler.persistence.api.PersistenceException.rethrow(PersistenceException.java:697)

at com.redwood.scheduler.persistence.spi.DatabaseHelper.executeQuery(DatabaseHelper.java:106)

at com.redwood.scheduler.persistence.impl.LowLevelPersistenceImpl.executeQueryRetry(LowLevelPersistenceImpl.java:491)

at com.redwood.scheduler.persistence.impl.LowLevelPersistenceImpl.access$1(LowLevelPersistenceImpl.java:481)

at com.redwood.scheduler.persistence.impl.LowLevelPersistenceImpl$1.execute(LowLevelPersistenceImpl.java:466)

at com.redwood.scheduler.persistence.impl.InnerPersistenceUnitOfWorkManager.execute(InnerPersistenceUnitOfWorkManager.java:35)

at com.redwood.scheduler.persistence.impl.LowLevelPersistenceImpl.executeQuery(LowLevelPersistenceImpl.java:460)

at com.redwood.scheduler.cluster.persistence.ClusteredLowLevelPersistence.executeQuery(ClusteredLowLevelPersistence.java:155)

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1096)

... 16 more

Caused by: com.redwood.scheduler.persistence.api.PersistenceException$UnknownObjectType: JCS-XXXXX: Unknown object type JobDefiniton in  aliases=false {Jp=JobDefinitionParameter, Jd=JobDefiniton}

at com.redwood.scheduler.persistence.sql.parser.SqlDictionaryResolver.getTableInfoAssert(SqlDictionaryResolver.java:229)

at com.redwood.scheduler.persistence.sql.parser.SqlDictionaryResolver.resolveTableFromDataDictionary(SqlDictionaryResolver.java:208)

Regards,

Ramana

there was a spelling mistake.

select Jp.* from JobDefinitionParameter Jp,JobDefinition Jd where Jp.Name = 'DIRECTORY' and Jp.JobDefinition=Jd.UniqueId and Jd.BranchedLLPVersion = -1

thanks

nanda

Oh my Bad. Thank you so so much. It worked like a charm.

Regards,

Ramana

Hi All,

I am trying to add a job definition parameter "JCS_USER"  to jobs of type "CMD" using the below script. But it gets errored if "JCS_USER" already exists for the jobs. Could you please help how to check in the code if the parameter already exists, if the parameter don't exist...add the parameter.

{

      String query = "select JobDefinition.* from JobDefinition where BranchedLLPVersion = -1";
      for (Iterator it = jcsSession.executeObjectQuery(query, null); it.hasNext();)

{
       JobDefinition jobdef = (JobDefinition) it.next(); 
      if (jobdef.getJobDefinitionType().getName().equals("CMD"))
      {
                  
        JobDefinitionParameter User = jobdef.createJobDefinitionParameter();
      
        User.setName("JCS_USER");
        User.setDefaultExpression("=Table.getColumnString('System_Variables', 'JCSUSR', 'SystemValue')");
       User.setDisplayOrder(new Long(30));
       User.setDirection(ParameterDirection.In);
       User.setDataType(ParameterType.String);
       jcsOut.println("Param2" + User.getName());
            jcsSession.persist();       

     }
    }

}

Thank you in advance,

Regards,

Ramana

I tried to change the script as below but it is returning only the null values. Please advise.

{

      String query = "select JobDefinition.* from JobDefinition where BranchedLLPVersion = -1";
      for (Iterator it = jcsSession.executeObjectQuery(query, null); it.hasNext();)

{
       JobDefinition jobdef = (JobDefinition) it.next(); 
     
      if (jobdef.getJobDefinitionType().getName().equals("CMD"))
      {
                  
       JobDefinitionParameter User = jobdef.createJobDefinitionParameter();
       jcsOut.println("Param1: " + User.getName());

       if((User.getName() != null) && (User.getName() != "JCS_USER"))
{      

        User.setName("JCS_USER");
        User.setDefaultExpression("=Table.getColumnString('System_Variables', 'JCSUSR', 'SystemValue')");
       User.setDisplayOrder(new Long(30));
       User.setDirection(ParameterDirection.In);
       User.setDataType(ParameterType.String);
            jcsSession.persist();
       jcsOut.println("Param2" + User.getName());  

}
else

{
  jcsOut.println("already exists: " + User.getName());
}   

     }
    }

}

Regards,

Ramana

Thank you all.

Below is the script.

{

      String query = "select JobDefinition.* from JobDefinition where BranchedLLPVersion = -1";
      for (Iterator it = jcsSession.executeObjectQuery(query, null); it.hasNext();)

{
     
      // JobDefinition jobdef = jcsSession.getJobDefinitionByName("CMD");
       JobDefinition jobdef = (JobDefinition) it.next(); 
      if (jobdef.getJobDefinitionType().getName().equals("CMD"))
      {
 
         // jcsOut.println("job name: " + jobdef.getName());
        JobDefinitionParameter parameterJCS;
       parameterJCS = jobdef.getJobDefinitionParameterByName("JCS_USER");

        if (parameterJCS == null)
{
          
        JobDefinitionParameter User = jobdef.createJobDefinitionParameter();           
        User.setName("JCS_USER");
        User.setDefaultExpression("=Table.getColumnString('System_Variables', 'JCSUSR', 'SystemValue')");
       User.setDisplayOrder(new Long(15));
       User.setDirection(ParameterDirection.In);
       User.setDataType(ParameterType.String);
            jcsSession.persist();
       jcsOut.println("Job name" + jobdef.getName());
       jcsOut.println("User name added" + User.getName());
         }

     }
    }

}

Regards,

Ramana

I recommend to modify the select statement to select job definitions of type 'CMD', this way you dont have to load all job definitions and then check for CMD type.

thanks

Nanda

Hi Nanda,

I tried to select the job defintions of type 'CMD' using the below query.

select JobDefinition.* from JobDefinition where JobDefinitionType = 'CMD' and BranchedLLPVersion = -1;

But I got the below error. So I went with the other approach. Please advise.

Caused by: com.redwood.scheduler.persistence.api.PersistenceException$RecoveryFailedException: JCS-XXXXX: Recovery failed: The SQL statement "SELECT "JCS_JOBDEF0"."F_ACTSUBJ","JCS_JOBDEF0"."A_BEHAVIOUR","JCS_JOBDEF0"."A_BRANCHLLP","JCS_JOBDEF0"."A_BRANCHMODTIMETS","JCS_JOBDEF0"."A_COMMENT","JCS_JOBDEF0"."A_CREATEDTS","JCS_JOBDEF0"."F_CRTIMEZONE","JCS_JOBDEF0"."F_DEFLOGFMT","JCS_JOBDEF0"."F_DEFOUTFMT","JCS_JOBDEF0"."F_QUEUE","JCS_JOBDEF0"."A_EXECUTIONCOUNT","JCS_JOBDEF0"."A_FAILEDEXECCOUNT","JCS_JOBDEF0"."A_SUMLOGSIZE","JCS_JOBDEF0"."A_SUMSQLOGSIZE","JCS_JOBDEF0"."A_SUMOUTPUTSIZE","JCS_JOBDEF0"."A_SUMSQOUTPUTSIZE","JCS_JOBDEF0"."A_SUMRUNTIME","JCS_JOBDEF0"."A_SUMSQRUNTIME","JCS_JOBDEF0"."A_DESCRIPTION","JCS_JOBDEF0"."A_EQUIV_OBJECT","JCS_JOBDEF0"."A_HOLDONSUBMIT","JCS_JOBDEF0"."F_JOBDEFTYPE","JCS_JOBDEF0"."F_JOBDEFTIMEZONE","JCS_JOBDEF0"."A_KEEPAMOUNT","JCS_JOBDEF0"."A_KEEPFORCE","JCS_JOBDEF0"."A_KEEPSTATUS","JCS_JOBDEF0"."A_KEEPTYPEEN","JCS_JOBDEF0"."A_KEEPUNITSEN","JCS_JOBDEF0"."A_LLPVERSION","JCS_JOBDEF0"."A_LASTMODIFTS","JCS_JOBDEF0"."F_LASTMODSUB","JCS_JOBDEF0"."A_MAINTENANCE","JCS_JOBDEF0"."F_MASTERJOBDEF","JCS_JOBDEF0"."A_MAXPRIORITY","JCS_JOBDEF0"."A_NAME","JCS_JOBDEF0"."A_OVERDUE","JCS_JOBDEF0"."F_OVERDUEEVTDEF","JCS_JOBDEF0"."A_OVERDUESTATUSEN","JCS_JOBDEF0"."A_OVERVIEWFMT","JCS_JOBDEF0"."F_CREATOR","JCS_JOBDEF0"."F_PARENTAPP","JCS_JOBDEF0"."F_PARTITION","JCS_JOBDEF0"."A_PRIORITY","JCS_JOBDEF0"."F_RESOURCE","JCS_JOBDEF0"."A_RESTARTCOUNT","JCS_JOBDEF0"."A_RETURNMAPTOCOMPL","JCS_JOBDEF0"."A_SEARCHNAME","JCS_JOBDEF0"."A_TEMPLATE","JCS_JOBDEF0"."F_TIMEWINDOW","JCS_JOBDEF0"."F_TIMEWINDOWTZ","JCS_JOBDEF0"."A_TOPLEVEL","JCS_JOBDEF0"."A_UNIQUEID" FROM "JCS_JOBDEF0" WHERE ("JCS_JOBDEF0"."A_UNIQUEID" IS NULL OR EXISTS (SELECT 1 FROM "JCS_JOBDEF0" "JCS__JD", "JCS_PARTITION0" "JCS__P", "JCS_ROLEGRANTEX0" "JCS__SRGE" WHERE "JCS_JOBDEF0"."F_MASTERJOBDEF" = "JCS__JD"."A_UNIQUEID" AND "JCS__JD"."F_PARTITION" = "JCS__P"."A_UNIQUEID" AND "JCS__SRGE"."F_GRANTEE" = 3723466 AND "JCS__P"."F_USERCLASS" IN (3) AND (EXISTS (SELECT 1 FROM "JCS_OBJPRIVGRANT0" "JCS__SOPG" WHERE "JCS__SOPG"."A_PRIVVIEW" = 't' AND "JCS__SOPG"."A_REFUID" = "JCS_JOBDEF0"."F_MASTERJOBDEF" AND "JCS__SOPG"."F_GRANTEE" = "JCS__SRGE"."F_GRANTED") OR EXISTS (SELECT 1 FROM "JCS_OBJDEF0" "JCS__OD", "JCS_TYPPRIVGRANT0" "JCS__SOTPG" WHERE "JCS__SOTPG"."F_OBJECTTYPE" = "JCS__OD"."A_UNIQUEID" AND "JCS__OD"."A_OBJECTNAME" = 'JobDefinition' AND "JCS__SOTPG"."A_PRIVVIEW" = 't' AND "JCS__SOTPG"."F_GRANTEE" = "JCS__SRGE"."F_GRANTED" AND ("JCS__SOTPG"."A_LEVELEN" = 'S' OR "JCS__SOTPG"."A_LEVELEN" = 'I' AND "JCS__SOTPG"."A_ISOGROUPPART" = "JCS__P"."F_USERCLASS" OR "JCS__SOTPG"."A_LEVELEN" = 'P' AND "JCS__SOTPG"."A_ISOGROUPPART" = "JCS__JD"."F_PARTITION"))))) AND "JCS_JOBDEF0"."F_JOBDEFTYPE" = 'CMD' AND "A_BRANCHLLP" =  - 1" contains the semantics error[s]: - 1:2353 - type check error: the left hand side >>"JCS_JOBDEF0"."F_JOBDEFTYPE"<< (BIGINT) and the right hand side >>'CMD'<< (CHAR) of a comparison operator are not comparable

at com.redwood.scheduler.persistence.helper.RetryThenFailAction.recover(RetryThenFailAction.java:71)

at com.redwood.scheduler.persistence.helper.RecoverySQLExceptionWrapper.wrapSQLException(RecoverySQLExceptionWrapper.java:95)

at com.redwood.scheduler.persistence.impl.InnerPersistenceUnitOfWorkManager.execute(InnerPersistenceUnitOfWorkManager.java:45)

at com.redwood.scheduler.persistence.impl.LowLevelPersistenceImpl.executeQuery(LowLevelPersistenceImpl.java:460)

at com.redwood.scheduler.cluster.persistence.ClusteredLowLevelPersistence.executeQuery(ClusteredLowLevelPersistence.java:155)

at com.redwood.scheduler.model.SchedulerSessionImpl.executeObjectQuery(SchedulerSessionImpl.java:1096)

... 16 more

Caused by: com.sap.sql.log.OpenSQLException: The SQL statement "SELECT "JCS_JOBDEF0"."F_ACTSUBJ","JCS_JOBDEF0"."A_BEHAVIOUR","JCS_JOBDEF0"."A_BRANCHLLP","JCS_JOBDEF0"."A_BRANCHMODTIMETS","JCS_JOBDEF0"."A_COMMENT","JCS_JOBDEF0"."A_CREATEDTS","JCS_JOBDEF0"."F_CRTIMEZONE","JCS_JOBDEF0"."F_DEFLOGFMT","JCS_JOBDEF0"."F_DEFOUTFMT","JCS_JOBDEF0"."F_QUEUE","JCS_JOBDEF0"."A_EXECUTIONCOUNT","JCS_JOBDEF0"."A_FAILEDEXECCOUNT","JCS_JOBDEF0"."A_SUMLOGSIZE","JCS_JOBDEF0"."A_SUMSQLOGSIZE","JCS_JOBDEF0"."A_SUMOUTPUTSIZE","JCS_JOBDEF0"."A_SUMSQOUTPUTSIZE","JCS_JOBDEF0"."A_SUMRUNTIME","JCS_JOBDEF0"."A_SUMSQRUNTIME","JCS_JOBDEF0"."A_DESCRIPTION","JCS_JOBDEF0"."A_EQUIV_OBJECT","JCS_JOBDEF0"."A_HOLDONSUBMIT","JCS_JOBDEF0"."F_JOBDEFTYPE","JCS_JOBDEF0"."F_JOBDEFTIMEZONE","JCS_JOBDEF0"."A_KEEPAMOUNT","JCS_JOBDEF0"."A_KEEPFORCE","JCS_JOBDEF0"."A_KEEPSTATUS","JCS_JOBDEF0"."A_KEEPTYPEEN","JCS_JOBDEF0"."A_KEEPUNITSEN","JCS_JOBDEF0"."A_LLPVERSION","JCS_JOBDEF0"."A_LASTMODIFTS","JCS_JOBDEF0"."F_LASTMODSUB","JCS_JOBDEF0"."A_MAINTENANCE","JCS_JOBDEF0"."F_MASTERJOBDEF","JCS_JOBDEF0"."A_MAXPRIORITY","JCS_JOBDEF0"."A_NAME","JCS_JOBDEF0"."A_OVERDUE","JCS_JOBDEF0"."F_OVERDUEEVTDEF","JCS_JOBDEF0"."A_OVERDUESTATUSEN","JCS_JOBDEF0"."A_OVERVIEWFMT","JCS_JOBDEF0"."F_CREATOR","JCS_JOBDEF0"."F_PARENTAPP","JCS_JOBDEF0"."F_PARTITION","JCS_JOBDEF0"."A_PRIORITY","JCS_JOBDEF0"."F_RESOURCE","JCS_JOBDEF0"."A_RESTARTCOUNT","JCS_JOBDEF0"."A_RETURNMAPTOCOMPL","JCS_JOBDEF0"."A_SEARCHNAME","JCS_JOBDEF0"."A_TEMPLATE","JCS_JOBDEF0"."F_TIMEWINDOW","JCS_JOBDEF0"."F_TIMEWINDOWTZ","JCS_JOBDEF0"."A_TOPLEVEL","JCS_JOBDEF0"."A_UNIQUEID" FROM "JCS_JOBDEF0" WHERE ("JCS_JOBDEF0"."A_UNIQUEID" IS NULL OR EXISTS (SELECT 1 FROM "JCS_JOBDEF0" "JCS__JD", "JCS_PARTITION0" "JCS__P", "JCS_ROLEGRANTEX0" "JCS__SRGE" WHERE "JCS_JOBDEF0"."F_MASTERJOBDEF" = "JCS__JD"."A_UNIQUEID" AND "JCS__JD"."F_PARTITION" = "JCS__P"."A_UNIQUEID" AND "JCS__SRGE"."F_GRANTEE" = 3723466 AND "JCS__P"."F_USERCLASS" IN (3) AND (EXISTS (SELECT 1 FROM "JCS_OBJPRIVGRANT0" "JCS__SOPG" WHERE "JCS__SOPG"."A_PRIVVIEW" = 't' AND "JCS__SOPG"."A_REFUID" = "JCS_JOBDEF0"."F_MASTERJOBDEF" AND "JCS__SOPG"."F_GRANTEE" = "JCS__SRGE"."F_GRANTED") OR EXISTS (SELECT 1 FROM "JCS_OBJDEF0" "JCS__OD", "JCS_TYPPRIVGRANT0" "JCS__SOTPG" WHERE "JCS__SOTPG"."F_OBJECTTYPE" = "JCS__OD"."A_UNIQUEID" AND "JCS__OD"."A_OBJECTNAME" = 'JobDefinition' AND "JCS__SOTPG"."A_PRIVVIEW" = 't' AND "JCS__SOTPG"."F_GRANTEE" = "JCS__SRGE"."F_GRANTED" AND ("JCS__SOTPG"."A_LEVELEN" = 'S' OR "JCS__SOTPG"."A_LEVELEN" = 'I' AND "JCS__SOTPG"."A_ISOGROUPPART" = "JCS__P"."F_USERCLASS" OR "JCS__SOTPG"."A_LEVELEN" = 'P' AND "JCS__SOTPG"."A_ISOGROUPPART" = "JCS__JD"."F_PARTITION"))))) AND "JCS_JOBDEF0"."F_JOBDEFTYPE" = 'CMD' AND "A_BRANCHLLP" =  - 1" contains the semantics error[s]: - 1:2353 - type check error: the left hand side >>"JCS_JOBDEF0"."F_JOBDEFTYPE"<< (BIGINT) and the right hand side >>'CMD'<< (CHAR) of a comparison operator are not comparable

at com.sap.sql.jdbc.common.StatementAnalyzerImpl.check(StatementAnalyzerImpl.java:38)

at com.sap.sql.jdbc.common.StatementAnalyzerImpl.preprepareStatement(StatementAnalyzerImpl.java:116)

Regards,

Ramana

hey Ramana,

JobDefinitionType values are stored in a different table, so the query should be

"select JobDefinition.* from JobDefinition, JobDefinitionType where JobDefinition.JobDefinitionType=JobDefinitionType.UniqueId and JobDefinitionType.Name='CMD'"

thanks

Nanda

Thank you so much Nanda:-)

Hi Gurbakhshinder Singh,

Do you have any OnJobStatusChange triggers defined ?

How many jobs are running in your SAP systems ?

Regards,

HP

Hi ,

Can someone help to provide me some report or script to extract all job chain details with all technical parameters like abap program ,external program , SAP user name . In other terms you can say whatever job definition is having parameters .It should show all details .

Thanks

Sharath

Hi Sharath ,

Please find attached script , this will extract all job chain details , including all parameters .Go to Job definition and select redwood script and paste this script .this will give you all job chain details ..

Thanks

Gurbakhsh

Hi Asif ,

Please find attached script , this will extract all job chain details . Hope this will resolve your problem.

Thanks

Gurbakhsh

Hi Brian,

Please find attached script , this will extract all job chain details . Hope this will resolve your problem.

Thanks

Gurbakhsh

Hello HP ,

Yes , we have on job status change trigger through which job failure alerts are created for status error ,killed etc . Your hint sounds me this trigger can create performence problems which looks quite valid point . Any other suggestions to trouble shoot such problem ..

Thanks

Gurbakhsh

excelllent script !!! thanks for this qucik help